This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
Fix bug with ES Index and Postgres Index DAOs colliding #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tgres and Elasticsearch are used in core
JumasJM
pushed a commit
to FRINXio/conductor-community
that referenced
this pull request
Oct 23, 2023
…tgres and Elasticsearch are used in core (Netflix#191)
JumasJM
pushed a commit
to FRINXio/conductor-community
that referenced
this pull request
Nov 6, 2023
…tgres and Elasticsearch are used in core (Netflix#191)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The addition of Postgres as an IndexDAO made it so that if you use Conductor core as your deployment mechanism, and you use Postgres and ES7, there is a collision now. The server fails to start because there are 2 IndexDAOs provided. There is a Configuration condition that does not appear to be working either.
But, this makes the correct assumption that if you're including ES7, then you intend to use ES7 as your indexing mechanism.
CC @bjpirt
Pull Request type
./gradlew generateLock saveLockto refresh dependencies)