Skip to content

Conversation

@kannann1
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 15, 2025
@popoveugene popoveugene changed the title doc: add namespace render filtering docs: Add BGD related changes in docs Sep 24, 2025
Copy link
Collaborator

@popoveugene popoveugene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. In all docs where the BG domain object is mentioned, replace credentialsId with credentials. Also, create a GitHub ticket for the effective set calculator so that it correctly generates bg_domain in the effective set.

  2. I don't understand the description of the following macros. It looks like the calculator computes them differently. Please clarify with Chethana.

    • BG_CONTROLLER_URL
    • CMDB_CALLBACK_URL
    • CMDB_CALLBACK_TOKEN
  3. I changed the NS filter macro from ${} to @.

  4. I removed the NS filter from template macros. I was wrong when I suggested adding it.
    The descriptions in namespace-render-filtering.md and instance-pipeline-parameters.md are sufficient.

  5. I made minor changes: 7c95ce6

@github-actions github-actions bot added the bug Something isn't working label Oct 7, 2025
@miyamuraga miyamuraga removed the bug Something isn't working label Oct 14, 2025
kannann1 and others added 2 commits October 24, 2025 13:55
Removed CMDB_CALLBACK_URL and CMDB_CALLBACK_TOKEN sections from the documentation, [corresponding issue](#745) has been created to remove these from the them from the code.
@github-actions github-actions bot added the bug Something isn't working label Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants