Skip to content

Handle command results by class instead of Func - #35

Merged
KubaZ2 merged 10 commits into
NetCordDev:alphafrom
csmir:enhancement/resulthandlingbyclass
Aug 9, 2024
Merged

Handle command results by class instead of Func#35
KubaZ2 merged 10 commits into
NetCordDev:alphafrom
csmir:enhancement/resulthandlingbyclass

Conversation

@csmir

@csmir csmir commented Aug 8, 2024

Copy link
Copy Markdown
Contributor

Squash again, will clear the branch later

Closes #34

@KubaZ2 KubaZ2 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the comments apply to all the services

Comment thread Hosting/NetCord.Hosting.Services/Commands/CommandHandler.cs Outdated
@csmir
csmir requested a review from KubaZ2 August 8, 2024 16:56
Comment thread Hosting/NetCord.Hosting.Services/Commands/CommandResultHandler.cs Outdated
@csmir
csmir requested a review from KubaZ2 August 9, 2024 19:09
@KubaZ2
KubaZ2 merged commit 8d7fbbd into NetCordDev:alpha Aug 9, 2024
@KubaZ2

KubaZ2 commented Aug 9, 2024

Copy link
Copy Markdown
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Result handling logic should be expanded to support class-based handlers.

2 participants