Feat: Adding poll support - #18
Merged
Merged
Conversation
Contributor
Author
|
It is worth noting that this is still WIP. Made a PR just so progress can be tracked |
Member
|
NetCord doesn't use |
Contributor
Author
|
Okay, will try to refactor with what you said in mind |
Contributor
Author
|
I also realized that I have to make IJsonModel wrappers for non-properties ( We discussed this in Discord ) |
KubaZ2
reviewed
Apr 17, 2024
- Removed usages required keyword ( Kuba said that this will be a breaking change ) - Renamed Expiry to ExpireAt for consistency - Use JsonEmoji instead of Emoji in json data-structures - Made wrapper entities
KubaZ2
requested changes
Apr 17, 2024
- Fixed type of answer_id
Co-authored-by: Kuba_Z2 <77853483+KubaZ2@users.noreply.github.com>
…lain about it, and it caused checks to fail earlier on ) - Fixed properties
- Namespace fix
Contributor
Author
|
Finally checks are passing |
…orks since my understanding of [GenerateAlias] is limited
KubaZ2
reviewed
Apr 17, 2024
KubaZ2
reviewed
Apr 17, 2024
KubaZ2
reviewed
Apr 17, 2024
KubaZ2
reviewed
Apr 17, 2024
Member
|
Thanks! |
Contributor
Author
|
You're welcome for nothing, sorry I haven't had time to work on it ( School sucks ) |
This was referenced Jun 8, 2026
This was referenced Jun 16, 2026
This was referenced Jun 25, 2026
This was referenced Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add poll support to NetCord.