Skip to content

Added missing flags and documentation to 'UserFlags.cs'. - #17

Merged
KubaZ2 merged 13 commits into
NetCordDev:alphafrom
Red-K0:patch-2
Apr 6, 2024
Merged

Added missing flags and documentation to 'UserFlags.cs'.#17
KubaZ2 merged 13 commits into
NetCordDev:alphafrom
Red-K0:patch-2

Conversation

@Red-K0

@Red-K0 Red-K0 commented Mar 26, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@KubaZ2

KubaZ2 commented Mar 26, 2024

Copy link
Copy Markdown
Member

The names should be PascalCase. Could you also replace spaces before and after the summary content with new lines and remove them after casting?

@Red-K0

Red-K0 commented Mar 26, 2024

Copy link
Copy Markdown
Contributor Author

The names should be PascalCase. Could you also replace spaces before and after the summary content with new lines and remove them after casting?

Yeah, all done.

@KubaZ2

KubaZ2 commented Mar 26, 2024

Copy link
Copy Markdown
Member

Could you also remove the 0 prefixes from bitfield values? They look odd for me. Also could you please split the values with new lines? I think it would make the code more readable.

@Red-K0

Red-K0 commented Mar 26, 2024

Copy link
Copy Markdown
Contributor Author

Could you also remove the 0 prefixes from bitfield values? They look odd for me. Also could you please split the values with new lines? I think it would make the code more readable.

Split and prefixes removed

@KubaZ2

KubaZ2 commented Mar 26, 2024

Copy link
Copy Markdown
Member

Could you also remove the empty spaces? I think it should be Name = value for all fields. I think the unnecessary indentation is useless.

@Red-K0

Red-K0 commented Mar 26, 2024

Copy link
Copy Markdown
Contributor Author

Could you also remove the empty spaces? I think it should be Name = value for all fields. I think the unnecessary indentation is useless.

Yeah that's more a remnant of how the code originally looked, removing it

Comment thread NetCord/UserFlags.cs
@Red-K0

Red-K0 commented Mar 26, 2024

Copy link
Copy Markdown
Contributor Author

Not sure why it didn't go through the first time, but extra space is removed

@KubaZ2

KubaZ2 commented Mar 26, 2024

Copy link
Copy Markdown
Member

I reminded myself that https://github.com/KubaZ2/NetCord/blob/alpha/NetCord%2FPermissions.cs are formatted with uL suffix instead of casting. Could you follow that convention?

@Red-K0

Red-K0 commented Mar 27, 2024

Copy link
Copy Markdown
Contributor Author

uL convention added

Comment thread NetCord/UserFlags.cs Outdated
Comment thread NetCord/UserFlags.cs Outdated
Comment thread NetCord/UserFlags.cs Outdated
@KubaZ2

KubaZ2 commented Mar 30, 2024

Copy link
Copy Markdown
Member

Could you also fix casing of private when it follows Undocumented and?

@Red-K0

Red-K0 commented Apr 4, 2024

Copy link
Copy Markdown
Contributor Author

Sorry for the delay, casings fixed

Comment thread NetCord/UserFlags.cs Outdated
Comment thread NetCord/UserFlags.cs Outdated
Comment thread NetCord/UserFlags.cs Outdated
BotHttpInteractions = 1uL << 19,

/// <summary>
/// Undocumented. User's account is disabled for spam.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it means the account is disabled. Other users have spammers' messages hidden by default as if they were blocked. Maybe something changed though.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No discord can actually just disable you for spam, had it happen to someone I know.

Discord has disabled your account for spam and/or platform abuse. Our anti-abuse measures may have flagged your account for any of the following behaviors:

  • Sending a large number of direct messages in a short span of time
  • Participating in a server dedicated to spamming Discord
  • Automating your user account or self-botting
  • Taking other actions on Discord — for example, joining a ton of servers — faster than humanly possible
  • Attempting potentially fraudulent activity

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how being a spammer used to look like.
image

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A spammer can be disabled or vice-versa. But even the non-disabled ones will have the flag, I checked in my own server @KubaZ2

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, that means that the comment isn't correct

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, question is what to change it to though. I could just leave it at "User's account is disabled."

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"User account is flagged as spammer"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added that instead then

Red-K0 and others added 3 commits April 4, 2024 16:42
Co-authored-by: Kuba_Z2 <77853483+KubaZ2@users.noreply.github.com>
Co-authored-by: Kuba_Z2 <77853483+KubaZ2@users.noreply.github.com>
@KubaZ2
KubaZ2 merged commit 5642e50 into NetCordDev:alpha Apr 6, 2024
@Red-K0
Red-K0 deleted the patch-2 branch April 17, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants