Bump mgds pin to latest master (fixes tokenizer thread-safety race) - #1587
Merged
Conversation
Picks up the fix for a thread-unsafe fast tokenizer race (RuntimeError: Already borrowed) that showed up training Krea 2, plus EncodeAnimaText, Krea2, and EncodeIdeogramText module additions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mgdsgit pin from9320a69to3a6994a(latestNerogar/mgdsmaster).RuntimeError: Already borrowed) that surfaced training Krea 2 with multiple dataloader threads. Fast tokenizers mutate shared Rust-side state on every call, which isn't safe when the same tokenizer instance is called concurrently; the fix adds a lock around the tokenizer calls inTokenize.get_item.Drafted by Claude