Better preset selection - #1578
Merged
Merged
Conversation
…ser configs training_presets/ had grown to ~50 flat files that were hard to scan in a single dropdown. The top-bar "Load Preset" control now mirrors whatever directory structure exists under training_presets/ as a cascading menu (group -> preset), instead of hardcoding a flat list. Presets were regrouped by model type as a first cut of that directory structure (Inpainting variants folded into their base model's directory, "Flux 2 [Dev, Klein]" renamed to "Flux 2"). Saving/loading a user's own config no longer writes into training_presets/; "Save config" and a new "Load config" button use native file dialogs rooted at a new training_configs/ directory instead. training_presets/.gitignore no longer needs to filter out user configs, so it's reduced to just excluding "#.json", the per-machine last-session-state file. Config-loading (file I/O, migration, secrets-merging) lives in TopBarController.load_config_from_file(), alongside the other business logic there; the view only syncs UI state from the result. Also replaces models/.gitkeep with models/.gitignore (same self-exempting "*" / "!.gitignore" convention), dropping the now-stale root .gitignore exception for the deleted .gitkeep file. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
dxqb
force-pushed
the
preset-model-type-dirs
branch
from
July 4, 2026 08:04
625b07e to
8966055
Compare
Rebuilding the tk.Menu on every open leaked a Menu widget per click; build it once at construction, matching the PySide6 preset_menu_button. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
better preset menu, and separate button for loading user configs
Test plan
pre-commit run --all-filespassesAI assistance