Qt thread safety - #1575
Merged
Merged
Conversation
sync_cloud_secrets() is called from the training thread when cloud setup fails, but updated the UI state var directly, mutating a Qt widget off the main thread. This causes an intermittent native segfault. Defer the update via schedule_on_main_thread, matching the other training-thread callbacks. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
update_status() and update_preview() are called from the video tool's background worker thread but mutated QTextEdit/QLabel widgets directly, risking the same native segfault as sync_cloud_secrets. Defer both through a new schedule_on_main_thread helper. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Qt is stricter that Ctk with regards to thread safety. Do all UI calls only from the main thread, not from the training thread (and not from the video tool worker thread CC @efhosci)
Test plan
pre-commit run --all-filespassesAI assistance