Fix full-finetune save crash when checkpointing + layer offloading are enabled + diffusers output format - #1574
Merged
Merged
Conversation
…e enabled copy.deepcopy(pipeline) in DtypeModelSaverMixin._copy_pipeline_to_dtype reaches the shared LayerOffloadConductor via the checkpoint layers, and the conductor holds torch.cuda.Stream/Event objects that cannot be pickled, raising "TypeError: cannot pickle 'Stream' object". Give LayerOffloadConductor a __deepcopy__ that shares the existing instance instead of copying it. deepcopy is only used at save time to build a dtype-converted CPU copy of the pipeline, where the conductor is never invoked, so sharing it is safe. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
LayerOffloadConductor has no reason to know about save-time deepcopy semantics. The actual problem is that OffloadCheckpointLayer holds a reference into the conductor (directly as a submodule attribute in the compile path, or via the layer's bound forward method monkey-patched onto the wrapped module in the non-compile path), so it is the layer, not the conductor, that should own the "don't deepcopy the conductor" behavior. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
dxqb
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
pre-commit run --all-filespassesAI assistance