fix: missing commit for #1518 - #1567
Merged
Merged
Conversation
Avoids attribute-name strings and the default-args("tokenizer",) that
implicitly assumed every model has a single "tokenizer" attribute.
dxqb
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #1518:
_copy_pipeline_to_dtypetook atokenizer_attrstuple of attribute-name strings, with a default of("tokenizer",). This fix passes the tokenizer objects directly instead, and drops the default so every caller states explicitly which tokenizers it protects.This addresses review feedback that came in on #1518 after it was already merged.
Test plan
pre-commit run --all-filespassesAI assistance
Drafted by Claude