Use decorator form for factory.register() - #1498
Merged
Merged
Conversation
factory.register() now detects whether its second argument is a type (direct call form for loops) or an enum key (decorator form), allowing implementations to declare themselves with @factory.register() directly on the class definition instead of imperative calls at the bottom of the file. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
dxqb
added a commit
that referenced
this pull request
Jun 4, 2026
dxqb
added a commit
that referenced
this pull request
Jun 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pythonic form of the factory pattern introduced by #1211