Phase 1 - Input validation - #1296
Conversation
…nts training if there are validation errors
…entry and dir_entry
for more information, see https://pre-commit.ci
…loat to be positive, delete dead code
…into input-validation
Intentional, its only an error if the user has the "Prevent Overwrites" toggle set to true.
This is the input validation component and we've established that:
Thus why I felt the need to add validation based on real world support examples. Its the top 3 issues we see after no git and wrong python
|
|
Calamador has started testing. Heres what he found:
|
hameerabbasi
left a comment
There was a problem hiding this comment.
Consider the line breaks optional. Most stuff is code quality only, not behavior changes.
|
All raised issues including prevent overwrites being true by default, have been addressed. Ready for merge by itself into main. Do not merge it into phase 2, nor merge phase 2 into it. |
--------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>


Since we no longer need auto-reversion, to ease review and deal with the seemingly corrupted git branch I have rewritten #908 as seperate PR's.
This PR does the following:
requiredparams andextra_validationfunctionality to enable input specific (and not reusable) validation.Importantly tooltips, auto-correction and friendly names and such have been intentionally excluded to keep files changed more managable 🙂
Tested on Linux and Windows.