Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RemovalRecord::validate does not verify that target_chunks.dictionary contains enough elements #151

Closed
Sword-Smith opened this issue May 10, 2024 · 0 comments
Closed

RemovalRecord::validate does not verify that target_chunks.dictionary contains enough elements #151

Sword-Smith opened this issue May 10, 2024 · 0 comments
Assignees
@Sword-Smith
Labels
bug Something isn't working

Comments

@Sword-Smith
Copy link
Member

This function only verifies that all the elements in the target_chunks dictionary are present. It does not verify that this dictionary contains entries for all indices that have slid out of the mutator set's active window.
@Sword-Smith Sword-Smith self-assigned this May 10, 2024
@Sword-Smith Sword-Smith added the bug Something isn't working label May 10, 2024
Sword-Smith added a commit that referenced this issue May 11, 2024
@Sword-Smith
mmr: Fix validation of removal records
48e2ede 
Don't just check all included MMR membership proofs, but also verify
that the correct MMR membership proofs are included.

This closes #151.
Sword-Smith added a commit that referenced this issue May 16, 2024
@Sword-Smith
mmr: Fix validation of removal records
7f82256 
Don't just check all included MMR membership proofs, but also verify
that the correct MMR membership proofs are included.

This closes #151.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sword-Smith Sword-Smith

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Sword-Smith