Turn zzModRing & ZZModRing into ResidueRing subtypes #1819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm sorry! Obviously, I didn't check this carefully enough yesterday evening. |
Since the element types of these ring types are subtypes of ResElem, the rings should be subtypes of ResidueRing. Otherwise some generic code gets confused (notably check_parent for ResElem). This lead to a wrong error in the OSCAR book's introduction notebook.
fingolfin
force-pushed
the
mh/ModRing-ResidueRing
branch
from
97866cf
to
61cc89c
Compare
|
Hrm, this changes messes up the |
thofma
reviewed
Jul 8, 2024
| @@ -410,7 +410,7 @@ The ring $\mathbb Z/n\mathbb Z$ for some $n$. See [`residue_ring`](@ref). | |||
| Implementation for the modulus being a machine integer [`Int`](@ref). | |||
| For the modulus being a [`ZZRingElem`](@ref) see [`ZZModRing`](@ref). | |||
| """ | |||
| @attributes mutable struct zzModRing <: Ring | |||
| @attributes mutable struct zzModRing <: ResidueRing{UInt} | |||
There was a problem hiding this comment.
I would argue that this should also be ResidueRing{ZZRingElem}?
There was a problem hiding this comment.
Well we have
julia> supertypes(zzModRingElem)
(zzModRingElem, ResElem{UInt64}, RingElem, NCRingElem, SetElem, Any)
and these should match, I think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the element types of these ring types are subtypes of ResElem, the
rings should be subtypes of ResidueRing. Otherwise some generic code
gets confused (notably check_parent for ResElem).
This lead to a wrong error in the OSCAR book's introduction notebook.