Conform Nemo to new FLINT random struct#1750
Merged
thofma merged 1 commit intoNemocas:masterfrom May 14, 2024
Merged
Conversation
* The GMP-state in a FLINT random context structure will no longer be expanded inside the struct, but rather a pointer to it. Hence, make Nemo compatible with this. * Do not use `flint_rand_alloc` and `flint_rand_free` for allocating the FLINT random context structure. This is in order to be able to use the same code for the new version of FLINT as well as the old version. * Use the new symbol names for the FLINT random functions if they are available. This is checked during the initialization of Nemo, where we check for the new symbol `flint_rand_init`.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1750 +/- ##
==========================================
- Coverage 84.82% 84.80% -0.03%
==========================================
Files 95 95
Lines 36957 36968 +11
==========================================
Hits 31350 31350
- Misses 5607 5618 +11 ☔ View full report in Codecov by Sentry. |
Member
|
Seems to not break anything for flint 3.1. No clue if this works for flint#master, since it is not tested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to flintlib/flint#1964:
The GMP-state in a FLINT random context structure will no longer be expanded inside the struct, but rather a pointer to it. Hence, make Nemo compatible with this.
Do not use
flint_rand_allocandflint_rand_freefor allocating the FLINT random context structure. This is in order to be able to use the same code for the new version of FLINT as well as the old version.Use the new symbol names for the FLINT random functions if they are available. This is checked during the initialization of Nemo, where we check for the new symbol
flint_rand_init.