Tests and fixes for factoring related methods #1596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- is_squarefree: zero is never square free, units always are - factor and factor_squarefree throw a uniform error if argument is zero - add a bunch of tests to verify the fixes above
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1596 +/- ##
==========================================
+ Coverage 84.06% 85.42% +1.36%
==========================================
Files 94 94
Lines 36870 42835 +5965
==========================================
+ Hits 30993 36590 +5597
- Misses 5877 6245 +368 ☔ View full report in Codecov by Sentry. |
|
It appears somewhere in Oscar we are factoring the zero polynomial. |
thofma
approved these changes
Dec 13, 2023
|
Let's see CI with oscar-system/Oscar.jl#3104 merged. |
lgoettgens
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_squarefree: zero is never square free, units always arefactorandfactor_squarefreethrow a uniform error if argument is zeroFixes #1594