Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement AbstractVector inference for ConvergentsIterator #1204

Closed
wants to merge 1 commit into from

Conversation

vtjnash
Copy link

@vtjnash vtjnash commented Nov 16, 2021

@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #1204 (24cb8a9) into master (a35f2a5) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1204      +/-   ##
==========================================
- Coverage   87.93%   87.92%   -0.02%     
==========================================
  Files          76       76              
  Lines       28336    28335       -1     
==========================================
- Hits        24918    24913       -5     
- Misses       3418     3422       +4     
Impacted Files Coverage Δ
src/gaussiannumbers/continued_fraction.jl 100.00% <100.00%> (ø)
src/Nemo.jl 27.11% <0.00%> (-1.70%) ⬇️
src/flint/fmpq.jl 93.76% <0.00%> (-0.30%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a35f2a5...24cb8a9. Read the comment docs.

@thofma
Copy link
Member

thofma commented Nov 19, 2021

Should be fixed by JuliaLang/julia#43106. Thanks @vtjnash for your help.

@thofma thofma closed this Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

last now broken for custom iterators on master
2 participants