Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove needs some sanitization #1174

Closed
tthsqe12 opened this issue Sep 15, 2021 · 1 comment · Fixed by #1184
Closed

remove needs some sanitization #1174

tthsqe12 opened this issue Sep 15, 2021 · 1 comment · Fixed by #1184

Comments

@tthsqe12
Copy link
Contributor

julia> R, z = FiniteField(fmpz(7), 5, "z")
julia> Rx, x = PolynomialRing(R, "x")
julia> remove(x, zero(Rx))

signal (11): Segmentation fault
in expression starting at REPL[5]:1
fq_inv at /workspace/srcdir/flint2-2.8.0/fq/inv.c:36
unknown function (ip: 0x7ff7c9802c4f)
unknown function (ip: (nil))
Allocations: 4365692 (Pool: 4364293; Big: 1399); GC: 4
Segmentation fault (core dumped)
@wbhart
Copy link
Contributor

wbhart commented Sep 15, 2021

Sure, but the docs do explicitly say if you try to remove the zero, the entire universe explodes. We should at least try to give people a feel for what we mean by that. :-)

lgoettgens added a commit to lgoettgens/AbstractAlgebra.jl that referenced this issue Oct 1, 2024
fingolfin pushed a commit to Nemocas/AbstractAlgebra.jl that referenced this issue Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants