Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add free_associative_algebra_type #1826

Merged

Conversation

lgoettgens
Copy link
Collaborator

This is analogous to dense_poly_ring_type and friends, and can be used to assert concrete types in downstream code that currently uses the abstract type FreeAssociativeAlgebra (even though we currently only have one subtype, namely Generic.FreeAssociativeAlgebra).

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.03%. Comparing base (3fe0405) to head (5abf56e).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/FreeAssociativeAlgebra.jl 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1826      +/-   ##
==========================================
- Coverage   88.03%   88.03%   -0.01%     
==========================================
  Files         119      119              
  Lines       29988    29992       +4     
==========================================
+ Hits        26399    26402       +3     
- Misses       3589     3590       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me

@lgoettgens lgoettgens merged commit 6be27f6 into Nemocas:master Oct 4, 2024
28 of 30 checks passed
@lgoettgens lgoettgens deleted the lg/free_associative_algebra_type branch October 4, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants