Avoid redundant bounds checks in is_zero_row and is_zero_column

[fingolfin]

Also change the methods as well as that one for is_zero_entry to apply to Julia matrices, too.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.02%. Comparing base (0f40154) to head (78d9f59).
Report is 3 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1802      +/-   ##
==========================================
+ Coverage   87.99%   88.02%   +0.02%     
==========================================
  Files         119      119              
  Lines       30073    30069       -4     
==========================================
+ Hits        26464    26467       +3     
+ Misses       3609     3602       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[fingolfin]

Measurements with this using ZZMatrix.

Before:

julia> @btime is_zero_row(A, 1);
  56.190 ns (0 allocations: 0 bytes)

julia> @btime is_zero_row(A, 2);
  32.780 ns (0 allocations: 0 bytes)

julia> @btime is_zero_row(A, 3);
  13.138 ns (0 allocations: 0 bytes)

After:

julia> A = zero_matrix(ZZ, 3, 100); A[2,50]=1; A[3,1] = 1;

julia> @btime is_zero_row(A, 1);
  43.012 ns (0 allocations: 0 bytes)

julia> @btime is_zero_row(A, 2);
  27.470 ns (0 allocations: 0 bytes)

julia> @btime is_zero_row(A, 3);
  11.678 ns (0 allocations: 0 bytes)

[lgoettgens]

LGTM, but let's wait for downstream tests to confirm