Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uses of unsafe arithmatics #1790

Merged
merged 4 commits into from
Sep 17, 2024
Merged

Conversation

lgoettgens
Copy link
Collaborator

one should not rely on modification of the first arg, but instead take the return value

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 4 lines in your changes missing coverage. Please review.

Project coverage is 88.00%. Comparing base (86996ee) to head (460e129).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/Matrix-Strassen.jl 92.00% 2 Missing ⚠️
src/Matrix.jl 33.33% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1790   +/-   ##
=======================================
  Coverage   87.99%   88.00%           
=======================================
  Files         117      117           
  Lines       30037    30037           
=======================================
+ Hits        26432    26434    +2     
+ Misses       3605     3603    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lgoettgens lgoettgens enabled auto-merge (squash) September 17, 2024 10:34
@lgoettgens lgoettgens merged commit 55d8a01 into Nemocas:master Sep 17, 2024
30 checks passed
@lgoettgens lgoettgens deleted the lg/unsafe-arith-2 branch September 17, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants