Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generalize ideal(...) fallbacks #1788

Merged
merged 1 commit into from
Sep 17, 2024
Merged

feat: generalize ideal(...) fallbacks #1788

merged 1 commit into from
Sep 17, 2024

Conversation

thofma
Copy link
Member

@thofma thofma commented Sep 17, 2024

  • pass on keyword arguments
  • generalize to NCRingElement

- pass on keyword arguments
- generalize to NCRingElement
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 87.99%. Comparing base (86996ee) to head (6390c71).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/Ideal.jl 0.00% 8 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1788   +/-   ##
=======================================
  Coverage   87.99%   87.99%           
=======================================
  Files         117      117           
  Lines       30037    30037           
=======================================
  Hits        26432    26432           
  Misses       3605     3605           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lgoettgens lgoettgens enabled auto-merge (squash) September 17, 2024 07:07
@lgoettgens lgoettgens merged commit a2571bb into master Sep 17, 2024
29 of 30 checks passed
@lgoettgens lgoettgens deleted the th/id branch September 17, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants