Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add coprime base #1785

Merged
merged 4 commits into from
Sep 17, 2024
Merged

feat: add coprime base #1785

merged 4 commits into from
Sep 17, 2024

Conversation

thofma
Copy link
Member

@thofma thofma commented Sep 16, 2024

No description provided.

@codecov Codecov
Copy link

codecov bot commented Sep 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.59459% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.01%. Comparing base (86996ee) to head (1eb0e45).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/algorithms/coprime_base.jl 94.59% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1785      +/-   ##
==========================================
+ Coverage   87.99%   88.01%   +0.01%     
==========================================
  Files         117      118       +1     
  Lines       30037    30074      +37     
==========================================
+ Hits        26432    26469      +37     
  Misses       3605     3605

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thofma
Copy link
Member Author

thofma commented Sep 16, 2024

Necessary for moving factor around. @fieker I renamed coprime_base_insert to coprime_base_push!.

@thofma thofma requested a review from fieker September 17, 2024 04:18
@thofma thofma merged commit b7adff7 into master Sep 17, 2024
30 checks passed
@thofma thofma deleted the th/coprimebase branch September 17, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgoettgens lgoettgens lgoettgens left review comments

@fieker fieker Awaiting requested review from fieker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thofma @lgoettgens