Breaking set_precision! changes
#1775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joschmitt
force-pushed
the
js/setbreaking
branch
from
d399d47
to
225232c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1775 +/- ##
==========================================
- Coverage 88.01% 88.01% -0.01%
==========================================
Files 118 118
Lines 30074 30043 -31
==========================================
- Hits 26470 26442 -28
+ Misses 3604 3601 -3 ☔ View full report in Codecov by Sentry. |
joschmitt
force-pushed
the
js/setbreaking
branch
from
225232c
to
8426bff
Compare
joschmitt
force-pushed
the
js/setbreaking
branch
from
8426bff
to
2f058a3
Compare
|
@joschmitt Do you have already branches downstream prepared for adapting to these changes? If yes, I will go ahead and include this in the breaking AA release right now. If not, let's talk later or tomorrow. |
|
Nemocas/Nemo.jl#1844 should be enough for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The breaking part of #1773.