Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add is_diagonal(A::MatrixElem) #1472

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Conversation

fingolfin
Copy link
Member

... as alias for LinearAlgebra.isdiag -- and replacement for the Nemo method.

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #1472 (1235238) into master (dd13b88) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1472   +/-   ##
=======================================
  Coverage   84.72%   84.73%           
=======================================
  Files         110      110           
  Lines       29365    29373    +8     
=======================================
+ Hits        24880    24889    +9     
+ Misses       4485     4484    -1     
Files Coverage Δ
src/AbstractAlgebra.jl 56.15% <ø> (ø)
src/Matrix.jl 91.75% <100.00%> (+0.01%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

... as alias for LinearAlgebra.isdiag -- and replacement
for the Nemo method.
@thofma thofma merged commit 1885232 into Nemocas:master Oct 27, 2023
14 of 15 checks passed
@fingolfin fingolfin deleted the mh/is_diagonal branch October 27, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants