Skip to content

Commit

Permalink
fix: typo in coprime base (#1798)
Browse files Browse the repository at this point in the history
  • Loading branch information
@thofma
thofma authored Sep 18, 2024
1 parent f38433a commit 0f40154
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/algorithms/coprime_base.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ function coprime_base(S::Vector{E}) where {E <: RingElement}
return coprime_base_steel(S)
end

function coprime_base_steel(S::Vector)
function coprime_base_steel(S::Vector{E}) where {E}
@assert !isempty(S)
T = Array{E}(undef, 1)
T[1] = S[1]
Expand Down

2 comments on commit 0f40154

@lgoettgens
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request updated: JuliaRegistries/General/115413

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.43.1 -m "<description of version>" 0f401540af7cf9d0b7880e13e8766700c0e65d0d
git push origin v0.43.1

Please sign in to comment.