Add suggested patches to gefs_replay_ci#7
Merged
NeilBarton-NOAA merged 7 commits intoAug 20, 2024
Merged
Conversation
Fix a bug in a variable check in the extractvars task where parenthesis in the variable name will prompt a false warning message.
7 tasks
Ice variables are extracted from the history files instead of the product files. This is necessary because there are certain ice variables that are needed that are only available in the history files and not the product files.
Author
|
@NeilBarton-NOAA Marking this as ready for review. Ice variables are being extracted from the history files instead of the product files. This is necessary because there are certain ice variables that are needed (e.g. melts, meltb) that are only available in the history files and not the product files. Alternatively, we could add those needed ice variables to the product files, but a PR would have to be submitted in the gfs_utils repository first. We should keep this in mind when we decide what files to archive in the archive task. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds some patches to your gefs_replay_ci branch that are related to the reforecast. I have left this as a draft for now because I will be adding a couple more modifications, such as add some variables that are missing.