add <formatter>.new/1 #145
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruslandoga
commented
Nov 27, 2024
ruslandoga
commented
Nov 27, 2024
ruslandoga
commented
Nov 28, 2024
| @@ -22,7 +22,8 @@ defmodule LoggerJSONTest do | |||
| end | |||
|
|
|||
| test "raises on invalid log level" do | |||
| message = "Log level should be one of 'debug', 'info', 'warn', 'error' values, got: :invalid" | |||
| message = | |||
| "Log level should be one of [:error, :info, :debug, :emergency, :alert, :critical, :warning, :notice] values, got: :invalid" | |||
There was a problem hiding this comment.
I can split this change into a separate PR if needed :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋
This PR adds a utility function to create formatters. Similar to
Logger.Formatter.new/1Some other ideas for this PR:
new/1to make it easier to use, right now the users need to know that there is a "Shared options" section in the LoggerJSON moduledoc, and I think people are usually too lazy to look for it :)new/1new/1?