build: add workarounds required to build tests #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
aleksuss
reviewed
Jan 18, 2024
Cargo.toml
Outdated
| # Required to build tests with near-sdk v4.1.1, see | ||
| # TODO(): Remove after upgrading to near-sdk v5. | ||
| [patch.crates-io] | ||
| parity-secp256k1 = {git = "https://github.com/paritytech/rust-secp256k1"} |
There was a problem hiding this comment.
I would recommend adding a hash commit because, in such a way, you download the latest code from the master branch which potentially could be broken.
There was a problem hiding this comment.
Good point! I’ve added a tag corresponding to the last release of the parity-secp256k1 crate.
Would you mind pointing that out here as well? The workaround recommended to the community is currently missing a tag (or anything else that pins the downloaded code).
mooori
changed the title
birchmd
approved these changes
Jan 18, 2024
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Override
parity-secp256k1Building tests may currently fail since a dependency of
near-sdkv4.1.1 (most recent release) has been yanked. Providing a patch is the recommended workaround.A new version of
near-sdkis planned to be released soon. Then this patch shouldn’t be required anymore (ref.).Update
scripts/fix-dependenciesBy now more recursive dependencies need to be downgraded manually for tests to build with MSRV 1.69.0. See this comment for details.