Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing Operator/Authority choice in line #616

Merged
merged 9 commits into from
Jan 11, 2024
Merged

fixing Operator/Authority choice in line #616

merged 9 commits into from
Jan 11, 2024

Conversation

ue71603
Copy link
Contributor

@ue71603 ue71603 commented Dec 18, 2023

like #613 #341 but against master

@ue71603 ue71603 added the bug Technical mistake, inconsistency with the documentation, etc. label Dec 18, 2023
@ue71603 ue71603 added this to the netex_1.2 milestone Dec 18, 2023
@ue71603 ue71603 mentioned this pull request Dec 18, 2023
Closed
@ue71603
Copy link
Contributor Author

ue71603 commented Dec 18, 2023

@skinkie I think one still can have additional operators. The main case is 1-1, but there are others. Or do you want to change it?

@ue71603
Copy link
Contributor Author

ue71603 commented Dec 21, 2023

fixed a bug I introduced
@skinkie @Aurige @Duex
it is currently possible to provide neither Authorithy nor Operator (and do everything in ResponsibilitySets).
If you don't want that, then intervene (btw this is what SBB is doing)

@ue71603 ue71603 added the needs documentation update The NeTEx document needs to be updated label Jan 9, 2024
@skinkie skinkie merged commit 9cc7be3 into master Jan 11, 2024
1 check passed
@skinkie skinkie deleted the fixingOperator/Authority-choice-in-LINE-(master) branch January 11, 2024 17:43
@trurlurl trurlurl added document has been updated NeTEx Document already updated and removed needs documentation update The NeTEx document needs to be updated labels Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Robbendebiene Robbendebiene Robbendebiene left review comments

@skinkie skinkie skinkie approved these changes

@Aurige Aurige Aurige approved these changes

@trurlurl trurlurl trurlurl approved these changes

Assignees

@Aurige Aurige

@duexw duexw

Labels
bug Technical mistake, inconsistency with the documentation, etc. document has been updated NeTEx Document already updated
Projects
None yet
Milestone
netex_1.2
Development

Successfully merging this pull request may close these issues.
6 participants
@ue71603 @skinkie @Aurige @Robbendebiene @trurlurl @duexw