update egui to 0.24 #305
Merged
update egui to 0.24 #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
z33ky
commented
Dec 25, 2023
| } = self.ctx.run(new_input, run_ui); | ||
|
|
||
| let needs_update_textures = !textures_delta.is_empty(); | ||
| let needs_repaint = repaint_after.is_zero() || needs_update_textures; | ||
| let needs_repaint = viewport_output.values().any(|output| output.repaint_delay.is_zero()) || needs_update_textures; |
There was a problem hiding this comment.
This is my best guess. FullOutput::repaint_after was removed in emilk/egui#3172 and I'm not sure how dealing with multiple viewports effects notan.
|
Hey thank you so much for the PR, I'll try to check and merge it in the next few days |
|
I am merging it, I need to do some changes but cannot push here, so I merge and then do the changes on develop, thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.