Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up of pull request #626 #627

Merged
merged 2 commits into from
Nov 11, 2021
+2 −2
Merged

Follow up of pull request #626 #627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9196fb5
Fix ReDoS in dice_coefficient
yetingli Nov 10, 2021
a805bc4
Repaired a test for Dice coefficient
Hugo-ter-Doest Nov 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/natural/distance/dice_coefficient.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ function intersect (set1, set2) {
function sanitize (str) {
// Turn characters to lower string, remove space at the beginning and end,
// replace multiple spaces in the middle by single spaces
return str.toLowerCase().replace(/^\s+|\s+$/g, '').replace(/s+/g, ' ')
return str.toLowerCase().replace(/\s+/g, ' ').replace(/^\s+|\s+$/g, '')
}

function diceCoefficient (str1, str2) {
Expand Down
2 changes: 1 addition & 1 deletion spec/dice_coefficient_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,6 @@ describe('dice', function () {
it('should compare complete texts', function () {
const text1 = require('./test_data/Wikipedia_EN_FrenchRevolution.json').text
const text2 = require('./test_data/Wikipedia_EN_InfluenceOfTheFrenchRevolution.json').text
expect(dice(text1, text2)).toBe(0.7897503285151117)
expect(dice(text1, text2)).toBe(0.7939374395356337)
})
})