Fix wrong input types

Nats-ji · Nov 24, 2022 · d247c0e · d247c0e
1 parent f9e7c6f
commit d247c0e
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 17 deletions.
diff --git a/action.yml b/action.yml
@@ -14,7 +14,6 @@ inputs:
   keep-old-minor-releases:
     description: 'Keep the latest release of each older minor versions.'
     required: true
-    default: true
   keep-old-minor-releases-by:
     description: 'Which semver level should we use to keep old release? Can be: major, minor, patch'
     required: false

diff --git a/dist/index.js b/dist/index.js
@@ -13105,20 +13105,24 @@ async function run() {
 
 try {
   // load options
-  Options.token = core.getInput("token");
-  Options.keepCount = core.getInput("keep-count");
-  Options.keepOld = core.getInput("keep-old-minor-releases");
+  Options.token = core.getInput("token", {required: true});
+  Options.keepCount = Number(core.getInput("keep-count"));
+  Options.keepOld = core.getBooleanInput("keep-old-minor-releases", {required: true});
   Options.keepOldBy =
     core.getInput("keep-old-minor-releases-by") === "major"
       ? 1
       : core.getInput("keep-old-minor-releases-by") === "patch"
       ? 3
       : 2;
-  Options.keepOldCount = core.getInput("keep-old-minor-releases-count");
-  Options.removeTags = core.getInput("remove-tags");
-  Options.dryRun = core.getInput("dry-run");
-  SemverOption.loose = core.getInput("semver-loose");
-  SemverOption.includePrerelease = core.getInput("include-prerelease");
+  Options.keepOldCount = Number(core.getInput("keep-old-minor-releases-count"));
+  Options.removeTags = core.getBooleanInput("remove-tags");
+  Options.dryRun = core.getBooleanInput("dry-run");
+  SemverOption.loose = core.getBooleanInput("semver-loose");
+  SemverOption.includePrerelease = core.getBooleanInput("include-prerelease");
+  if (isNaN(Options.keepCount))
+    throw new Error("Input is not a number: keep-count")
+  if (isNaN(Options.keepOldCount))
+    throw new Error("Input is not a number: keep-old-minor-releases-count")
 
   run();
 } catch (error) {

diff --git a/index.js b/index.js
@@ -272,20 +272,24 @@ async function run() {
 
 try {
   // load options
-  Options.token = core.getInput("token");
-  Options.keepCount = core.getInput("keep-count");
-  Options.keepOld = core.getInput("keep-old-minor-releases");
+  Options.token = core.getInput("token", {required: true});
+  Options.keepCount = Number(core.getInput("keep-count"));
+  Options.keepOld = core.getBooleanInput("keep-old-minor-releases", {required: true});
   Options.keepOldBy =
     core.getInput("keep-old-minor-releases-by") === "major"
       ? 1
       : core.getInput("keep-old-minor-releases-by") === "patch"
       ? 3
       : 2;
-  Options.keepOldCount = core.getInput("keep-old-minor-releases-count");
-  Options.removeTags = core.getInput("remove-tags");
-  Options.dryRun = core.getInput("dry-run");
-  SemverOption.loose = core.getInput("semver-loose");
-  SemverOption.includePrerelease = core.getInput("include-prerelease");
+  Options.keepOldCount = Number(core.getInput("keep-old-minor-releases-count"));
+  Options.removeTags = core.getBooleanInput("remove-tags");
+  Options.dryRun = core.getBooleanInput("dry-run");
+  SemverOption.loose = core.getBooleanInput("semver-loose");
+  SemverOption.includePrerelease = core.getBooleanInput("include-prerelease");
+  if (isNaN(Options.keepCount))
+    throw new Error("Input is not a number: keep-count")
+  if (isNaN(Options.keepOldCount))
+    throw new Error("Input is not a number: keep-old-minor-releases-count")
 
   run();
 } catch (error) {