Skip to content

Fix/google maps ground overlay#303

Merged
triniwiz merged 3 commits intoNativeScript:mainfrom
tommag21:fix/google-maps-ground-overlay
Jul 15, 2022
Merged

Fix/google maps ground overlay#303
triniwiz merged 3 commits intoNativeScript:mainfrom
tommag21:fix/google-maps-ground-overlay

Conversation

@tommag21
Copy link
Contributor

@tommag21 tommag21 commented Jul 15, 2022

@nativescript/google-maps

Fixes the ground overlay feature (#300) and some incorrect style typings.

@cla-bot
Copy link

cla-bot bot commented Jul 15, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Tommaso Guerri.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@tommag21
Copy link
Contributor Author

tommag21 commented Jul 15, 2022

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Jul 15, 2022

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @tommag21.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@cla-bot
Copy link

cla-bot bot commented Jul 15, 2022

The cla-bot has been summoned, and re-checked this pull request!

@tommag21
Copy link
Contributor Author

tommag21 commented Jul 15, 2022

@cla-bot check

@cla-bot cla-bot bot added the cla: yes label Jul 15, 2022
@cla-bot
Copy link

cla-bot bot commented Jul 15, 2022

The cla-bot has been summoned, and re-checked this pull request!

@triniwiz
Copy link
Member

triniwiz commented Jul 15, 2022

Thank you

@triniwiz triniwiz merged commit 0413bac into NativeScript:main Jul 15, 2022
NathanWalker pushed a commit that referenced this pull request Jul 21, 2022
@tommag21 @NathanWalker
fix(google-maps): ground overlay (#303)
535d95f 
* fixes android ground overlay from position

* adds ground overlay from bounds

* fixes map style
triniwiz pushed a commit that referenced this pull request Aug 4, 2022
@herefishyfish @tommag21
fix(google-maps): map type missing (#309)
a041572 
* Fix/google maps ground overlay (#303)

* fixes android ground overlay from position

* adds ground overlay from bounds

* fixes map style

* add iOS map type

Co-authored-by: tomma_g <38555316+tommag21@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tommag21 @triniwiz