Skip to content

fix: resolve pacote regression with creating app from a template directory #5766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2023
Merged

fix: resolve pacote regression with creating app from a template directory #5766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/services/pacote-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import { INpmConfigService, INodePackageManager } from "../declarations";
import { IProxyService, IFileSystem } from "../common/declarations";
import { IInjector } from "../common/definitions/yok";
import { injector } from "../common/yok";
import { Arborist } from "@npmcli/arborist";

export class PacoteService implements IPacoteService {
constructor(
Expand All @@ -32,7 +33,8 @@ export class PacoteService implements IPacoteService {
`Calling pacoteService.manifest for packageName: '${packageName}' and options: `,
options
);
const manifestOptions: IPacoteBaseOptions = await this.getPacoteBaseOptions();
const manifestOptions: IPacoteBaseOptions =
await this.getPacoteBaseOptions();

if (options) {
_.extend(manifestOptions, options);
Expand Down Expand Up @@ -117,7 +119,7 @@ export class PacoteService implements IPacoteService {

// Add NPM Configuration to our Manifest options
const npmConfig = this.$npmConfigService.getConfig();
const pacoteOptions = _.extend(npmConfig, { cache: cachePath });
const pacoteOptions = _.extend(npmConfig, { cache: cachePath, Arborist });
const proxySettings = await this.$proxyService.getCache();
if (proxySettings) {
_.extend(pacoteOptions, proxySettings);
Expand Down
Loading