Skip to content

fix: pass allowProvisioningUpdates to xcodebuild only when building for device #5077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 16, 2019
Merged

fix: pass allowProvisioningUpdates to xcodebuild only when building for device #5077

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45f1870
fix: pass allowProvisioningUpdates to xcodebuild only when building f…
Fatme Oct 15, 2019
e051ea1
chore: fix unit tests
Fatme Oct 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/services/ios/xcodebuild-args-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,8 @@ export class XcodebuildArgsService implements IXcodebuildArgsService {
const args = [
"archive",
"-archivePath", archivePath,
"-configuration", buildConfig.release ? Configurations.Release : Configurations.Debug
"-configuration", buildConfig.release ? Configurations.Release : Configurations.Debug,
'-allowProvisioningUpdates'
]
.concat(this.getXcodeProjectArgs(platformData.projectRoot, projectData, ProductArgs.scheme))
.concat(architectures)
Expand Down Expand Up @@ -92,8 +93,7 @@ export class XcodebuildArgsService implements IXcodebuildArgsService {

args = args.concat([
"BUILD_DIR=" + path.join(platformData.projectRoot, constants.BUILD_DIR),
'SHARED_PRECOMPS_DIR=' + path.join(platformData.projectRoot, 'build', 'sharedpch'),
'-allowProvisioningUpdates'
'SHARED_PRECOMPS_DIR=' + path.join(platformData.projectRoot, constants.BUILD_DIR, 'sharedpch')
]);

return args;
Expand Down