Skip to content

Conversation

@jzgoda
Copy link
Contributor

@jzgoda jzgoda commented Sep 25, 2019

PR Checklist

Fixes #5034

I also added a test to help prevent this from happening again.

@cla-bot cla-bot bot added the cla: yes label Sep 25, 2019
@Fatme
Copy link
Contributor

Fatme commented Sep 25, 2019

test-cli-templates cli-device cli-run

@Fatme
Copy link
Contributor

Fatme commented Sep 25, 2019

@jzgoda,

Really nice work! Thank you for contribution!

I'm running additional integration tests and we'll merge your PR after green builds.

@Fatme Fatme merged commit 033032a into NativeScript:master Sep 26, 2019
@jzgoda jzgoda deleted the fix-iCloudContainerEnvironment branch September 26, 2019 13:54
@Fatme Fatme added this to the 6.2.0 milestone Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken build option --i-cloud-container-environment

2 participants