fix: handle invalid runtime versions and Android P livesync #3759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitarTachev
force-pushed
the
tachev/fix-issues
branch
2 times, most recently
from
48cd712 to
08fb97a
Compare
rosen-vladimirov
approved these changes
Jul 19, 2018
DimitarTachev
force-pushed
the
tachev/fix-issues
branch
from
08fb97a to
7ae0697
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
The live sync is not working on Android P.
There is an infinite loader when a nonexisting runtime is specified in the package.json.
What is the new behavior?
The live sync is working on Android P.
An error is shown when a nonexisting runtime is specified in the package.json.
Related to issue #3602