feat: Speed up adding native platform #3735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current logic for adding native platform is: 1. Install the runtime package (tns-ios or tns-android) as a dependency of the project 2. Copy all files from the `<project dir>/node_modules/<runtime package>/framework` to `<project dir>/plaforms/<platform>/...` (specific places there). 3. Uninstall the runtime package, so it is no longer dependency of the project. This solution becomes really slow when the project has a lot of dependencies. For example, for `tns-template-master-detail-ng`, all these steps take around 2 mins and 5 seconds on Windows (without SSD) and around 40 seconds on macOS (with SSD). In order to speed up this process, remove the installing and uninstalling of the runtime package. Instead of this, use the `pacote` package to extract the runtime to a directory in the `temp` and copy files from there to `platforms` directory. As we do not execute `npm install` and `npm uninstall` with this solution, the operation is not dependant on the number of dependencies used in the project. It takes around 5-9 second on both Windows and macOS. Also remove the usage of `$options` from `npmInstallationManager` - its purpose was to work with `--frameworkPath` on `tns platform add <platform>` command, but we no longer call `npmInstallationManager` for this case. Fix the tests for `platorm-service`'s addPlatform method as they were incorrectly passing.
|
run ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current logic for adding native platform is:
<project dir>/node_modules/<runtime package>/frameworkto<project dir>/plaforms/<platform>/...(specific places there).This solution becomes really slow when the project has a lot of dependencies. For example, for
tns-template-master-detail-ng, all these steps take around 2 mins and 5 seconds on Windows (without SSD) and around 40 seconds on macOS (with SSD).In order to speed up this process, remove the installing and uninstalling of the runtime package. Instead of this, use the
pacotepackage to extract the runtime to a directory in thetempand copyfiles from there to
platformsdirectory. As we do not executenpm installandnpm uninstallwith this solution, the operation is not dependent on the number of dependencies used in the project. It takesaround 5-9 second on both Windows and macOS.
Also remove the usage of
$optionsfromnpmInstallationManager- its purpose was to work with--frameworkPathontns platform add <platform>command, but we no longer callnpmInstallationManagerfor this case.Fix the tests for
platorm-service's addPlatform method as they were incorrectly passing.PR Checklist
What is the current behavior?
tns platform add <platform>takes around 40 secondsWhat is the new behavior?
tns platform add <platform>takes around 6 seconds.Fixes/Implements/Closes #[Issue Number].