Skip to content

Use async API from ios-sim #3599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fatme merged 2 commits into from
Jun 29, 2018
Merged

Use async API from ios-sim #3599

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4de023f
Use async API from ios-sim
Fatme May 14, 2018
61a0a80
Update ios-sim-portable to latest version
Fatme Jun 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/common
Open in desktop
Submodule common updated 5 files
+2 −2 appbuilder/providers/device-app-data-provider.ts
+1 −1 definitions/mobile.d.ts
+3 −3 mobile/ios/simulator/ios-simulator-application-manager.ts
+1 −1 mobile/ios/simulator/ios-simulator-device.ts
+2 −2 mobile/ios/simulator/ios-simulator-log-provider.ts
2 changes: 1 addition & 1 deletion lib/device-path-provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export class DevicePathProvider implements IDevicePathProvider {
public async getDeviceProjectRootPath(device: Mobile.IDevice, options: IDeviceProjectRootOptions): Promise<string> {
let projectRoot = "";
if (this.$mobileHelper.isiOSPlatform(device.deviceInfo.platform)) {
projectRoot = device.isEmulator ? this.$iOSSimResolver.iOSSim.getApplicationPath(device.deviceInfo.identifier, options.appIdentifier) : LiveSyncPaths.IOS_DEVICE_PROJECT_ROOT_PATH;
projectRoot = device.isEmulator ? await this.$iOSSimResolver.iOSSim.getApplicationPath(device.deviceInfo.identifier, options.appIdentifier) : LiveSyncPaths.IOS_DEVICE_PROJECT_ROOT_PATH;

if (!projectRoot) {
this.$errors.failWithoutHelp("Unable to get application path on device.");
Expand Down