clean-up after release build in android to prevent runtime errors #2452
Conversation
lib/services/ios-project-service.ts
Outdated
| } | ||
|
|
||
| public cleanProject(projectRoot: string, options: string[]): IFuture<void> { | ||
| return null; |
There was a problem hiding this comment.
It's better to use:
return Future.fromResult();This way the code will not fail in case the method is called (currently in case you call cleanProject(..).wait() it will fail that it cannot read property wait fo null.
| let changesInfo = this.$projectChangesService.checkForChanges(platform); | ||
| if (changesInfo.hasChanges) { | ||
| // android build artifacts need to be cleaned up when switching from release to debug builds | ||
| if (platform.toLowerCase() === "android") { |
There was a problem hiding this comment.
As the whole logic is Android specific, instead of using this if, you can move the whole code inside AndroidProjectService's cleanProject method. Here you can just call:
platformData.platformProjectService.cleanProject(platformData.projectRoot, []).wait();There was a problem hiding this comment.
Thought about that earlier, but I don't think cleanProject should depend on conditions specific to the prepare phase, and the android test prevents unnecessary prepareInfo checks when preparing an ios project.
lib/services/platform-service.ts
Outdated
| if (platform.toLowerCase() === "android") { | ||
| let previousPrepareInfo = this.$projectChangesService.getPrepareInfo(platform); | ||
| // clean up prepared plugins when not building for release | ||
| if (previousPrepareInfo && previousPrepareInfo.release && !this.$options.release) { |
There was a problem hiding this comment.
Isn't it good idea to call the clean method in case the previous build was for debug config and the current one is for release? For example:
if (previousPrepareInfo && previousPrepareInfo.release !== this.$options.release) {There was a problem hiding this comment.
Good point! Build artifacts should be cleaned when changing the build type. Don't know why I didn't leave it that way.
petekanev
force-pushed
the
pete/patch-release--debug-android-build
branch
from
413e271 to
9495948
Compare
|
👍 After green build, of course ;) |
petekanev
force-pushed
the
pete/patch-release--debug-android-build
branch
from
9495948 to
2302507
Compare
If app's built with the
--releaseoption, the settings are recorded in.nsprepareinfoin theplatforms/androiddirectory. If the file is present, and follow up builds are not built in release, then the project directory is cleaned manually to ensure that no build artifacts specific to just release (like the android snapshot binaries) are packaged into the debug application.File changes:
IPlatformProjectServiceand created a stub on the ios side.androidAddresses #2443