-
-
Notifications
You must be signed in to change notification settings - Fork 198
Description
Environment
Provide version numbers for the following components (information can be retrieved by running tns info in your project folder or by inspecting the package.json of the project):
- CLI: 5.4.0
- Cross-platform modules:5.4.0
- Android Runtime:5.4.0
- iOS Runtime:5.4.0
- Plugin(s): dev-webpack: 0.24.0
Describe the bug
With tns preview, the production dependencies of the Preview app are marked as external modules and excluded from vendor.js in order to be used from the Preview app itself.
However, when scanning on iOS, the tns-core-modules are included in vendor.js. The reason for this behavior is the additional inspector-modules iOS entry point which is an entry point from an external module. The file contains relative requests to other files inside tns-core-modules and our externals logic is not detecting them.
To Reproduce
tns create jsApp --js && cd jsApptns preview- Scan with iOS device
- Take a look at
./platforms/ios/jsApp/app/vendor.js.
Expected behavior
The file must be a few hundred lines containing only the runtime part of some dev-dependencies but it's containing the whole tns-core-modules module.