Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #175 'native:migrate fresh' command does not work #198

Merged
merged 2 commits into from
Apr 28, 2024

Conversation

me-shaon
Copy link
Contributor

Closes #175

Why

The previous implementation of native:migrate fresh command conflicted with the base native:migrate command implementation and showed the error described in the issue.

Changes

  • Updated the FreshCommand implementation to extend it from the base FreshCommand of the Illuminate Console command and updated the signature to keep it similar to the base command.
  • Updated the NativeServiceProvider to add this new command.

@me-shaon
Copy link
Contributor Author

@mpociot not sure why the tests are failing. Let me know if I need to fix anything in this PR.

@Phr33d0m
Copy link

Phr33d0m commented Nov 7, 2023

Hi, any news on this one? It is quite the show-stopper.

@me-shaon
Copy link
Contributor Author

@mpociot can you please take a look at it?

@LunashaGit
Copy link
Contributor

@mpociot not sure why the tests are failing. Let me know if I need to fix anything in this PR.

Hello !

I have the same issues,
BUT :
I've done the tests in the local environment and everything's fine, because I've opened NativePHP ( which uses localhost:4000 ) and almost all the tests work, only one crashes ( Maybe because I'm on Windows, I'm not sure ).

-> #249

@simonhamp simonhamp self-assigned this Apr 1, 2024
@simonhamp
Copy link
Member

This looks fine. I just need to spend some time fixing the tests

@simonhamp simonhamp mentioned this pull request Apr 28, 2024
@simonhamp
Copy link
Member

Ok, I've been digging into the test failures and I think it's a slightly wider issue than we need to resolve here, so I'm going to merge this and fix the tests separately

@simonhamp simonhamp merged commit 89793a9 into NativePHP:main Apr 28, 2024
@me-shaon me-shaon deleted the fix/issue-175 branch April 29, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: 'native:migrate fresh' does not work
4 participants