downgrade electron-builder#251
Merged
gwleuverink merged 3 commits intomainfrom Sep 4, 2025
Merged
Conversation
SRWieZ
approved these changes
Sep 4, 2025
Member
SRWieZ
left a comment
SRWieZ
left a comment
There was a problem hiding this comment.
Bummer, but let's go for the fix!
simonhamp
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/NativePHP/laravel/issues/613
Lots of people are reporting build issue on Windows. Debugging this was a headache but I finally found it.
Apparently
electron-buildermade significant changes to how the dependency tree is searched and ever since it seems it doesn't take platform requirements into account. Causing it to try and resolve a package that is correctly not included in node_modules. This mechanism is used to decide what node_modules should be moved to the asar archive.I was able to track it down to this PR: electron-userland/electron-builder#9010
And later found others with a similar issue: electron-userland/electron-builder#9259 (comment)
I've tried plenty of workarounds but after discovering the code that causes this it became apparent I cannot really patch around the issue. This pull request downgrades electron-builder back to
^25.I'll keep an eye on the issue in the
electron-builderrepo. We should be able to bump it back to^26if that issue is resolved on their side.