-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sequencing report service #230
Update sequencing report service #230
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 nice work!
I had a few question/comments.
Also, I think bimonthly
is behind monthly
. If possible to bring it up-to-date, I think the PR would be much cleaner.
roles/arteria-sequencing-report-ws/templates/pipeline_configs/demultiplex.yml.j2
Outdated
Show resolved
Hide resolved
roles/arteria-sequencing-report-ws/templates/pipeline_configs/seqreports.yml.j2
Outdated
Show resolved
Hide resolved
c153ad0
to
11e05e2
Compare
Thanks for the reviews! I'll make a separate PR to update |
32a1e4f
to
05e5801
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, I left some comments for you.
roles/arteria-sequencing-report-ws/files/nextflow_configs/demultiplex.config
Outdated
Show resolved
Hide resolved
roles/arteria-sequencing-report-ws/files/nextflow_configs/demultiplex.config
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 looks good to me
instead of having separate folders for each pipeline
Co-authored-by: Matilda Åslin <[email protected]>
fdb373c
to
4f2d976
Compare
This PR updates the sequencing report service and adds nf-core/demultiplex to the deployment
This new version contains many new features but for this release we will only validate it can still work as before.