Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort language detection results by descending score #800

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

osma
Copy link
Member

@osma osma commented Sep 17, 2024

This is an improvement to the language detection REST API method (#631) which improves the implementation that was made in #659.

Results are now sorted by descending score, so the most likely language is returned first.

@osma osma added this to the 1.2 milestone Sep 17, 2024
@osma osma self-assigned this Sep 17, 2024
Copy link

sonarcloud bot commented Sep 17, 2024

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.65%. Comparing base (c42a93f) to head (8564c12).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #800   +/-   ##
=======================================
  Coverage   99.65%   99.65%           
=======================================
  Files          93       93           
  Lines        6889     6889           
=======================================
  Hits         6865     6865           
  Misses         24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@juhoinkinen juhoinkinen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@osma osma merged commit c81ed1c into main Sep 17, 2024
17 checks passed
@osma osma deleted the issue631-language-detection-rest-sort-by-score branch September 17, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants