-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies for v1.1 release - round 2 #786
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #786 +/- ##
==========================================
- Coverage 99.65% 99.64% -0.02%
==========================================
Files 89 91 +2
Lines 6405 6768 +363
==========================================
+ Hits 6383 6744 +361
- Misses 22 24 +2 ☔ View full report in Codecov by Sentry. |
Also SciPy v1.13.0 has been relesased, and we could update to it from v1.12, but there is a breaking change
which affects Gensim. Fortunately they have already fixed this in their development branch, and hopefully there will soon be a release to include the fix. |
The HTTP backend imports requests, so requests needs to be always installed
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Continuation to #771.
Also makes requests a regular dependency instead of a test dependency, because the HTTP backend imports requests, so requests needs to be always installed.