Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python version in GH Actions CI/CD pipeline #717

Merged
merged 5 commits into from
Jun 30, 2023

Conversation

juhoinkinen
Copy link
Member

@juhoinkinen juhoinkinen commented Jun 27, 2023

All test jobs were running tests on Python 3.10 although the intent was to use the versions defined in the job configurations matrix, i.e. 3.8, 3.9 and 3.10. This was noticeable only(?) in the output of the pytest step, which for all jobs was

platform linux -- Python 3.10.6, pytest-7.4.0, pluggy-1.2.0

(And from noticing that everything worked after adding Python 3.11 to the matrix (#703), which was because 3.10 was actually used.)

Although the "Set up Python" step installed the Python versions defined in the matrix as requested, Poetry was installed with pipx, which in turn seemed to be (pre-)installed on Python 3.10, and this version remained to be used in the Poetry venv.

Now the Python version from the matrix is set to be used in Poetry venv by poetry env use <Python-version> command.

Also upgrades Poetry to v1.5.1.

@juhoinkinen juhoinkinen added this to the 1.0 milestone Jun 27, 2023
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (98603a9) 99.67% compared to head (1442f03) 99.67%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #717   +/-   ##
=======================================
  Coverage   99.67%   99.67%           
=======================================
  Files          89       89           
  Lines        6380     6380           
=======================================
  Hits         6359     6359           
  Misses         21       21           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@juhoinkinen juhoinkinen marked this pull request as ready for review June 27, 2023 12:20
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@juhoinkinen juhoinkinen merged commit 320af2b into main Jun 30, 2023
@juhoinkinen juhoinkinen deleted the fix-python-version-in-gh-actions branch June 30, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant