Update GitHub Actions #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #587 +/- ##
=======================================
Coverage 99.48% 99.48%
=======================================
Files 84 86 +2
Lines 5615 5645 +30
=======================================
+ Hits 5586 5616 +30
Misses 29 29
Continue to review full report at Codecov.
|
juhoinkinen
force-pushed
the
upgrade-gh-actions
branch
from
aa7f909
to
0847e25
Compare
This reverts commit 0847e25.
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades GH Actions to latest versions, and pins the codecov and pypi-publish Actions commit hashes.
Upgrading codecov Action (from v1 to v3) necessitates generating the coverage report in xml format (apparently this applies to both v2 and v3).
Also makes the coverage report upload conditional: it is uploaded only by Python 3.8 test run. Until now, the report was uploaded three times (by Python 3.7, 3.8 and 3.9 runs). That may be the reason for weird coverage changes I have noticed (the coverage is different for different Python versions, and it is somewhat random which run finishes last, and I think the report by the last run overrides earlier ones).Now I chose to upload the report by Python 3.8 run. This evens out the the running times (very slightly). This means the test coverage of NN ensemble, Omikuji and Yake backends is not tracked, while of fastText and spaCy code it is.Edit: Actually codecov merges the reports that are uploaded by different runs, so it is desired to upload all of them as previously.