Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tags trigger to GH Actions CI workflow #581

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

juhoinkinen
Copy link
Member

In PR #574 the general push event workflow trigger was replaced by a branch-specific push trigger (namely push.branches.master). However, this or any branch-specific push trigger does not fire on pushing tags (even to the selected branch); there has to be also the tags trigger, as explained in the docs.

I already tried to make the 0.57 release by pushing tags, which did not work out. So, I'll merge this fix, update the git tag, and push the tags again, and then the release workflow/job is supposed to be run...

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #581 (0fa6327) into master (0fc9a05) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #581   +/-   ##
=======================================
  Coverage   99.47%   99.47%           
=======================================
  Files          84       84           
  Lines        5568     5568           
=======================================
  Hits         5539     5539           
  Misses         29       29           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fc9a05...0fa6327. Read the comment docs.

@juhoinkinen juhoinkinen merged commit 306a53e into master Mar 15, 2022
@juhoinkinen juhoinkinen deleted the gh-actions-tags-trigger branch March 15, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant